The new Python API for the ifp module (re #1812)#1849
Merged
maliberty merged 23 commits intoSep 20, 2022
Merged
Conversation
Open
QuantamHD
reviewed
May 12, 2022
The dbLib's name is generated from the lef file_name. Per GH feedback from Ethan. Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
QuantamHD
reviewed
May 18, 2022
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
proppy
reviewed
May 24, 2022
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
proppy
reviewed
May 24, 2022
proppy
reviewed
May 24, 2022
proppy
reviewed
May 24, 2022
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
QuantamHD
reviewed
Aug 12, 2022
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
The generated file names in test logs differ between tcl and python so the new suppress_message command is used to hide them in the unit tests. This means each test must include helper.tcl and have its results updated. Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
Finished Python tests for ifp
Signed-off-by: Matt Liberty <mliberty@eng.ucsd.edu>
maliberty
changed the title
maliberty
approved these changes
Sep 20, 2022
Member
|
With Don's help, this is now to the point of being ready to merge. There will be a lot more PRs for subsequent modules but this sets the style. |
This was referenced Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no intention to merge this anytime soon. It is public just for collaborating with other contributors.
A simple example is in src/ifp/test/init_floorplan1.py